Merged
Conversation
kere-nel
requested review from
JakeRadMSFT,
LittleLittleCloud,
harishsk and
justinormont
kere-nel
force-pushed
the
ranking
branch
2 times, most recently
from
d89d1e9 to
705a436
Compare
Codecov Report
@@ Coverage Diff @@
## master #5150 +/- ##
==========================================
+ Coverage 73.47% 73.57% +0.09%
==========================================
Files 1010 1013 +3
Lines 187974 188446 +472
Branches 20261 20289 +28
==========================================
+ Hits 138120 138649 +529
+ Misses 44372 44316 -56
+ Partials 5482 5481 -1
|
| ColumnInformation columnInfo, IDataView validationSet) | ||
| { | ||
| LightGbmRankingTrainer.Options options = TrainerExtensionUtil.CreateLightGbmOptions<LightGbmRankingTrainer.Options, | ||
| float, RankingPredictionTransformer<LightGbmRankingModelParameters>, LightGbmRankingModelParameters>(sweepParams, columnInfo); |
src/Microsoft.ML.AutoML/TrainerExtensions/TrainerExtensionCatalog.cs
Outdated
Show resolved
Hide resolved
|
|
||
| // remove column with 'GroupId' purpose | ||
| var groupColumnName = intermediateCols.FirstOrDefault(c => c.Purpose == ColumnPurpose.GroupId)?.ColumnName; | ||
| concatColNames.RemoveAll(s => s == groupColumnName); |
Member
There was a problem hiding this comment.
You also need to remove "GroupId" too because it's a key column, it can't be cocat.
Contributor
Author
There was a problem hiding this comment.
I moved the custom GroupId column change to another PR. That's why there's only groupColumnName removed here.
src/Microsoft.ML.CodeGenerator/CodeGenerator/CSharp/TrainerGenerators.cs
Outdated
Show resolved
Hide resolved
...lTests/ConsoleCodeGeneratorTests.ConsoleAppModelBuilderCSFileContentRankingTest.approved.txt
Outdated
Show resolved
Hide resolved
JakeRadMSFT
approved these changes
Jun 12, 2020
LittleLittleCloud
approved these changes
Jun 17, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a ranking experiment in AutoML - sweeping over predefined parameters for two trainers - FastTreeRanking and LightGBMRanking.
ModelBuilder Requests:
Next Steps: Fully integrate with modelbuilder