-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Updated libmf and corresponding MatrixFactorizationSimpleTrainAndPredict() baselines per build #5121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Updated libmf and corresponding MatrixFactorizationSimpleTrainAndPredict() baselines per build #5121
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
49e7af6
Updated libmf and corresponding MatrixFactorizationSimpleTrainAndPred…
mstfbl ca3f3d0
Updated for slight variance in CentOS 7
mstfbl a9cd532
Remove tolerance
mstfbl 733513a
Updated baselines for Ubuntu and Linux, added back tolerance
mstfbl f9df598
Removed CentOS 7 specific check
mstfbl 67787c8
Removed extra braces and space
mstfbl d119545
Updated name of expectedLinuxMeanSquaredError
mstfbl 995df7f
Added explanation of varying but consistent metrics
mstfbl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is MatrixFactorizationFact needed? #Resolved
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it is not! Currently,
MatrixFactorizationFactis just anEnvironmentSpecificFactAttributethat always returnstruewithIsEnvironmentSupported(). In a seperate PR, I'll be marking theseMatrixFactorizationFactmarked tests asFact, and if possible, remove theMatrixFactorizationFactfrom the codebase all together. #ResolvedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already done in below PR: #5122
In reply to: 424743738 [](ancestors = 424743738)