Adding vector tests for KeyToValue and ValueToKey#5090
Merged
harishsk merged 10 commits intodotnet:masterfrom May 8, 2020
Merged
Adding vector tests for KeyToValue and ValueToKey#5090harishsk merged 10 commits intodotnet:masterfrom
harishsk merged 10 commits intodotnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5090 +/- ##
==========================================
- Coverage 75.66% 75.65% -0.01%
==========================================
Files 993 993
Lines 178168 178170 +2
Branches 19122 19126 +4
==========================================
- Hits 134802 134799 -3
- Misses 38143 38146 +3
- Partials 5223 5225 +2
|
Contributor
nit: Please add a newline above. But more importantly, ValueToKeyMapping (and related) transforms have caused a bunch of issues in Nimbus. Can you please run the Nimbus suite of tests and make sure that nothing is broken there as a result of these changes? #Resolved Refers to: src/Microsoft.ML.Data/Transforms/ValueToKeyMappingTransformer.cs:813 in ebea3a0. [](commit_id = ebea3a0, deletion_comment = False) |
harishsk
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.