Skip to content

ColumnSelectingTransformer now infers ONNX shape #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelgsharp merged 2 commits into from
May 6, 2020
Merged

ColumnSelectingTransformer now infers ONNX shape #5079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dedbe44
ColumnSelectingTransformer now infers ONNX shape
michaelgsharp May 1, 2020
a11a347
Updated test baseline
michaelgsharp May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Data/Transforms/ColumnSelecting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ public void SaveAsOnnx(OnnxContext ctx)
continue;

var srcVariable = ctx.GetVariableName(srcCol.Name);
var dstVariable = ctx.AddIntermediateVariable(dstCol.Type, dstCol.Name, true);
var dstVariable = ctx.AddIntermediateVariable(dstCol.Type, dstCol.Name);
string opType = "Identity";
ctx.CreateNode(opType, srcVariable, dstVariable, ctx.GetNodeName(opType), "");
}
Expand Down
72 changes: 72 additions & 0 deletions test/BaselineOutput/Common/Onnx/Transforms/SelectColumns.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,78 @@
}
}
},
{
"name": "Size1",
"type": {
"tensorType": {
"elemType": 1,
"shape": {
"dim": [
{
"dimValue": "-1"
},
{
"dimValue": "1"
}
]
}
}
}
},
{
"name": "Shape0",
"type": {
"tensorType": {
"elemType": 6,
"shape": {
"dim": [
{
"dimValue": "-1"
},
{
"dimValue": "1"
}
]
}
}
}
},
{
"name": "Thickness0",
"type": {
"tensorType": {
"elemType": 11,
"shape": {
"dim": [
{
"dimValue": "-1"
},
{
"dimValue": "1"
}
]
}
}
}
},
{
"name": "Label0",
"type": {
"tensorType": {
"elemType": 9,
"shape": {
"dim": [
{
"dimValue": "-1"
},
{
"dimValue": "1"
}
]
}
}
}
},
{
"name": "Size.output",
"type": {
Expand Down