Skip to content

Fix SsaForecast bug #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frank-dong-ms-zz merged 3 commits into from
Apr 14, 2020
Merged

Fix SsaForecast bug #5023

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b567a56
fix SsaForecast
frank-dong-ms-zz Apr 13, 2020
e1b1c70
refind comments
frank-dong-ms-zz Apr 13, 2020
f2a798a
remove static fields to local variable
frank-dong-ms-zz Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ML.TimeSeries/PolynomialUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,8 @@ public static bool FindPolynomialCoefficients(Complex[] roots, ref Double[] coef

if (destinationOffset < n - 1)
{
if (Utils.Size(PolynomialFactor.Destination) < n)
PolynomialFactor.Destination = new decimal[n];
// always clean up Destination to avoid random test failure
PolynomialFactor.Destination = new decimal[n];

while (factors.Count > 1)
{
Expand Down
2 changes: 0 additions & 2 deletions test/Microsoft.ML.TimeSeries.Tests/TimeSeriesDirectApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,6 @@ public void ChangePointDetectionWithSeasonalityPredictionEngine()
}

[LessThanNetCore30OrNotNetCoreFact("netcoreapp3.1 output differs from Baseline")]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void SsaForecast()
{
var env = new MLContext(1);
Expand Down