Skip to content

Bitmap(file) locks the file. #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ganik merged 2 commits into from
Apr 2, 2020
Merged

Bitmap(file) locks the file. #4994

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
849d274
construct new Bitmap(file) locks the underlying file for the lifetime…
ganik Apr 1, 2020
45aeb6c
Maintain original pixel format from file.
ganik Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Microsoft.ML.ImageAnalytics/ImageLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ private Delegate MakeGetterImageDataViewType(DataViewRow input, int iinfo, Func<
if (!string.IsNullOrWhiteSpace(_parent.ImageFolder))
path = Path.Combine(_parent.ImageFolder, path);

dst = new Bitmap(path) { Tag = path };
// to avoid locking file, use the construct below to load bitmap
using(var bmpTemp = new Bitmap(path))
dst = new Bitmap(bmpTemp) { Tag = path };

// Check for an incorrect pixel format which indicates the loading failed
if (dst.PixelFormat == System.Drawing.Imaging.PixelFormat.DontCare)
Expand Down