Fixes KMeans scoring differences between ORT and OnnxRunner#4942
Merged
kere-nel merged 2 commits intodotnet:masterfrom Mar 14, 2020
Merged
Fixes KMeans scoring differences between ORT and OnnxRunner#4942kere-nel merged 2 commits intodotnet:masterfrom
kere-nel merged 2 commits intodotnet:masterfrom
Conversation
harishsk
reviewed
Mar 13, 2020
harishsk
approved these changes
Mar 14, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KMeans ORT score predictions were off because batches were not being handled correctly.
There is still an issue because Nimbus produces int32 predictions, when they should be uint32, since ML.NET returns key values, but I plan on working on that separately, since it's probably a Nimbus bug.