Fix off by 1 error with the cats_int64s attribute for the OneHotEncoder ONNX operator#4827
Merged
harishsk merged 2 commits intodotnet:masterfrom Feb 12, 2020
Merged
Fix off by 1 error with the cats_int64s attribute for the OneHotEncoder ONNX operator#4827harishsk merged 2 commits intodotnet:masterfrom
harishsk merged 2 commits intodotnet:masterfrom
Conversation
…er ONNX operator.
harishsk
reviewed
Feb 12, 2020
Contributor
harishsk
left a comment
harishsk
left a comment
There was a problem hiding this comment.
It is a good idea to run all the tests in OnnxConversionTest.cs to verify if this change is breaking something else.
Contributor
Author
|
I just ran those tests and added two more off by 1 fixes for the unit tests. The changes have been added to the pull request. |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 4827 in repo dotnet/machinelearning |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.