added in support for System.DateTime type for the DateTimeTransformer#4661
Merged
michaelgsharp merged 3 commits intodotnet:masterfrom Jan 22, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4661 +/- ##
=========================================
Coverage ? 75.86%
=========================================
Files ? 951
Lines ? 172447
Branches ? 18646
=========================================
Hits ? 130834
Misses ? 36444
Partials ? 5169
|
harishsk
reviewed
Jan 17, 2020
harishsk
reviewed
Jan 17, 2020
test/Microsoft.ML.Tests/Transformers/DateTimeTransformerTests.cs
Outdated
Show resolved
Hide resolved
harishsk
reviewed
Jan 17, 2020
harishsk
reviewed
Jan 17, 2020
harishsk
reviewed
Jan 17, 2020
harishsk
reviewed
Jan 17, 2020
eerhardt
reviewed
Jan 17, 2020
eerhardt
reviewed
Jan 17, 2020
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in support to the
DateTimeTransformerto use columns ofDateTimetype.Removed the thread safe caching as its faster to just query the native code multiple times then to deal with the thread safe cache.