Convert LdaEngine to a SafeHandle#4538
Merged
sharwell merged 1 commit intodotnet:masterfrom Dec 9, 2019
Merged
Conversation
sharwell
commented
Dec 7, 2019
sharwell
commented
Dec 7, 2019
sharwell
commented
Dec 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #4538 +/- ##
==========================================
+ Coverage 75.12% 75.12% +<.01%
==========================================
Files 908 908
Lines 160214 160220 +6
Branches 17250 17250
==========================================
+ Hits 120355 120365 +10
+ Misses 35045 35039 -6
- Partials 4814 4816 +2
|
This comment has been minimized.
This comment has been minimized.
0cbfa54 to
bd45716
Compare
Contributor
Author
|
With changes to the native library now merged (#4551), I reduced this pull request to the minimum necessary to stabilize the use of this particular handle. It specifically fixes cases where this exception appears in test runs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request follows the test failure observed in https://dev.azure.com/dnceng/public/_build/results?buildId=449759&view=ms.vss-test-web.build-test-results-tab&runId=14347330&resultId=100770&paneView=debug. Converting this object to a SafeHandle has two primary advantages: