Merged
Conversation
codemzs
reviewed
Dec 6, 2019
| [CombinatorialData] | ||
| public void LpNormOnnxConversionTest( | ||
| bool ensureZeroMean, | ||
| LpNormNormalizingEstimatorBase.NormFunction norm) |
Member
There was a problem hiding this comment.
I assume it will infer all possible values in this case since they are discrete?
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
==========================================
- Coverage 75.13% 75.11% -0.03%
==========================================
Files 908 908
Lines 160238 160163 -75
Branches 17256 17250 -6
==========================================
- Hits 120401 120307 -94
- Misses 35016 35040 +24
+ Partials 4821 4816 -5
|
4488ef4 to
d520f81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
[Theory]to break up tests in OnnxConversionTest.📝 Builds on #4532 and #4545
💡 Recommended review strategy is commit-by-commit. The final commit is easier to review with whitespace-only changes hidden.