Avoid running API Compat for design time builds#4529
Merged
sharwell merged 1 commit intodotnet:masterfrom Dec 8, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4529 +/- ##
==========================================
+ Coverage 75.11% 75.13% +0.01%
==========================================
Files 908 908
Lines 160238 160238
Branches 17256 17256
==========================================
+ Hits 120362 120394 +32
+ Misses 35060 35029 -31
+ Partials 4816 4815 -1
|
a6281c2 to
8b730a4
Compare
This change prevents the API compat tool from failing design time builds and leaving the IDE project model in a bad state for development.
8b730a4 to
c9625e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents the API compat tool from failing design time builds and leaving the IDE project model in a bad state for development.