Skip to content

Adds PriorTrainer Onnx conversion#4515

Merged
kere-nel merged 4 commits intodotnet:masterfrom
kere-nel:onnx_prior_trainer
Dec 17, 2019
Merged

Adds PriorTrainer Onnx conversion#4515
kere-nel merged 4 commits intodotnet:masterfrom
kere-nel:onnx_prior_trainer

Conversation

@kere-nel
Copy link
Contributor

@kere-nel kere-nel commented Dec 3, 2019

  1. Adding Onnx support for PriorTrainer
    To follow the onnx construction pattern of other binary classifiers, this trainer uses the probability to predict labels, instead of score

@kere-nel kere-nel requested a review from a team as a code owner December 3, 2019 01:07
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@kere-nel kere-nel requested a review from harishsk December 9, 2019 22:50
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #4515 into master will decrease coverage by <.01%.
The diff coverage is 97.77%.

@@            Coverage Diff             @@
##           master    #4515      +/-   ##
==========================================
- Coverage   75.12%   75.12%   -0.01%     
==========================================
  Files         909      909              
  Lines      160267   160305      +38     
  Branches    17257    17258       +1     
==========================================
+ Hits       120406   120427      +21     
- Misses      35049    35060      +11     
- Partials     4812     4818       +6
Flag Coverage Δ
#Debug 75.12% <97.77%> (-0.01%) ⬇️
#production 70.52% <97.61%> (-0.01%) ⬇️
#test 90.29% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...Microsoft.ML.Data/Scorers/PredictionTransformer.cs 91.07% <100%> (+0.18%) ⬆️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 95.54% <100%> (ø) ⬆️
...StandardTrainers/Standard/Simple/SimpleTrainers.cs 84.9% <100%> (+2.81%) ⬆️
....ML.Data/Scorers/SchemaBindablePredictorWrapper.cs 74.52% <83.33%> (ø) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <0%> (-3.37%) ⬇️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 86.39% <0%> (-1.14%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0%> (-0.85%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 84.6% <0%> (+0.15%) ⬆️
... and 1 more

Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kere-nel kere-nel merged commit dc7ddb4 into dotnet:master Dec 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants