Ensure BufferBlocks are completed and empty in RowShufflingTransformer.#4479
Merged
eerhardt merged 2 commits intodotnet:masterfrom Nov 22, 2019
Merged
Ensure BufferBlocks are completed and empty in RowShufflingTransformer.#4479eerhardt merged 2 commits intodotnet:masterfrom
eerhardt merged 2 commits intodotnet:masterfrom
Conversation
stephentoub
reviewed
Nov 14, 2019
stephentoub
reviewed
Nov 14, 2019
stephentoub
approved these changes
Nov 14, 2019
antoniovs1029
approved these changes
Nov 15, 2019
Contributor
antoniovs1029
left a comment
antoniovs1029
left a comment
There was a problem hiding this comment.
I ran a couple of use cases using the changes in this PR, and it does solve the problem of the memory leak while debugging.
If BufferBlock doesn't get completed and drained of its items, it will have non-completed Tasks. When debugging in VS, this will appear to be a memory leak because VS adds all running Tasks to a static Dictionary, and then removes them when the Task is complete. If the Task doesn't get completed, it won't be removed from the Dictionary - thus it looks like a leak. Note there is no leak when the VS Debugger isn't attached because the non-completed Tasks don't get added to the static Dictionary. Fix dotnet#4399
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If BufferBlock doesn't get completed and drained of its items, it will have non-completed Tasks. When debugging in VS, this will appear to be a memory leak because VS adds all running Tasks to a static Dictionary, and then removes them when the Task is complete. If the Task doesn't get completed, it won't be removed from the Dictionary - thus it looks like a leak.
Note there is no leak when the VS Debugger isn't attached because the non-completed Tasks don't get added to the static Dictionary.
Fix #4399