Skip to content

Fixes onnx exports for regression trainers#4448

Merged
kere-nel merged 2 commits intodotnet:masterfrom
kere-nel:onnx_regression_trainers
Nov 23, 2019
Merged

Fixes onnx exports for regression trainers#4448
kere-nel merged 2 commits intodotnet:masterfrom
kere-nel:onnx_regression_trainers

Conversation

@kere-nel
Copy link
Contributor

@kere-nel kere-nel commented Nov 6, 2019

This PR fixes the issues with exporting the following regression trainers to onnx:

  • LbfgsPoissonRegression
  • FastTreeTweedie
  • FastForest

And adds onnx conversion tests for the following regression trainers:

  • FastTree
  • OnlineGradientDescent
  • Ols
  • LightGbm
  • Sdca

@kere-nel kere-nel requested a review from a team as a code owner November 6, 2019 22:32
@kere-nel kere-nel requested a review from harishsk November 6, 2019 22:33
@kere-nel kere-nel requested review from a team and KsenijaS November 6, 2019 22:41
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1fa6cb5). Click here to learn what that means.
The diff coverage is 90.47%.

@@            Coverage Diff            @@
##             master    #4448   +/-   ##
=========================================
  Coverage          ?   74.84%           
=========================================
  Files             ?      908           
  Lines             ?   159980           
  Branches          ?    17236           
=========================================
  Hits              ?   119744           
  Misses            ?    35404           
  Partials          ?     4832
Flag Coverage Δ
#Debug 74.84% <90.47%> (?)
#production 70.22% <100%> (?)
#test 90.08% <82.97%> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.FastTree/FastTree.cs 80.64% <100%> (ø)
...StandardTrainers/Standard/LinearModelParameters.cs 61.06% <100%> (ø)
src/Microsoft.ML.FastTree/FastTreeTweedie.cs 58.02% <100%> (ø)
...rc/Microsoft.ML.FastTree/RandomForestRegression.cs 70.43% <100%> (ø)
test/Microsoft.ML.Tests/OnnxConversionTest.cs 94.49% <82.97%> (ø)

@kere-nel kere-nel requested a review from ganik November 11, 2019 21:03
@kere-nel kere-nel closed this Nov 18, 2019
@kere-nel kere-nel force-pushed the onnx_regression_trainers branch from c886e5c to b7db4fa Compare November 18, 2019 22:44
@kere-nel kere-nel reopened this Nov 18, 2019
@harishsk harishsk closed this Nov 22, 2019
@harishsk harishsk reopened this Nov 22, 2019
@kere-nel kere-nel force-pushed the onnx_regression_trainers branch from 011c3e1 to 1114e54 Compare November 23, 2019 01:08
@kere-nel kere-nel merged commit 5c09ee6 into dotnet:master Nov 23, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments