Skip to content

Remove TensorFlow.Redist since we no longer use it. #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eerhardt merged 1 commit into from
Oct 17, 2019
Merged

Remove TensorFlow.Redist since we no longer use it. #4338

eerhardt merged 1 commit into from
Oct 17, 2019

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Oct 15, 2019

No description provided.

@eerhardt eerhardt requested a review from a team as a code owner October 15, 2019 21:49
@eerhardt
Copy link
Member Author

eerhardt commented Oct 16, 2019

This is green and ready to be reviewed.

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #4338 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4338      +/-   ##
==========================================
- Coverage   74.56%   74.54%   -0.02%     
==========================================
  Files         879      879              
  Lines      154524   154524              
  Branches    16883    16883              
==========================================
- Hits       115218   115197      -21     
- Misses      34554    34578      +24     
+ Partials     4752     4749       -3
Flag Coverage Δ
#Debug 74.54% <ø> (-0.02%) ⬇️
#production 70.12% <ø> (-0.03%) ⬇️
#test 89.55% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.AutoML/Sweepers/ISweeper.cs 59.49% <0%> (-7.6%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 77.96% <0%> (-5.09%) ⬇️
...icrosoft.ML.AutoML/Experiment/SuggestedPipeline.cs 88.17% <0%> (-4.31%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <0%> (-0.85%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 73.93% <0%> (+0.32%) ⬆️

harishsk
harishsk approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt merged commit a54a431 into dotnet:master Oct 17, 2019
@eerhardt eerhardt deleted the RemoveTFRedist branch October 17, 2019 00:29
@eerhardt eerhardt mentioned this pull request Oct 17, 2019
Merged
frank-dong-ms-zz pushed a commit to frank-dong-ms-zz/machinelearning that referenced this pull request Nov 4, 2019
@eerhardt @frank-dong-ms
Remove TensorFlow.Redist since we no longer use it. (dotnet#4338)
17dc951
@justinormont justinormont mentioned this pull request Apr 7, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@codemzs codemzs Awaiting requested review from codemzs

@yaeldekel yaeldekel Awaiting requested review from yaeldekel

1 more reviewer

@harishsk harishsk harishsk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eerhardt @harishsk