Skip to content

Issue 4120, add reasonable exception when user try to use OnnxSequenceType attribute without specify sequence type #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frank-dong-ms-zz merged 8 commits into from
Oct 4, 2019
Merged

Issue 4120, add reasonable exception when user try to use OnnxSequenceType attribute without specify sequence type #4272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ec26518
fix issue 4120, add reasonable exception when user try to use OnnxSeq…
frank-dong-ms Oct 1, 2019
7958922
rename function for better readibility
frank-dong-ms Oct 1, 2019
6c90cb2
take comments and modify accordingly
frank-dong-ms Oct 2, 2019
b201e17
take eric's comments, comment out default constructor instead of thro…
frank-dong-ms Oct 2, 2019
1885987
refine comments
frank-dong-ms Oct 2, 2019
18eff2d
remove unnecessary code change
frank-dong-ms Oct 2, 2019
2067f7d
Merge https://github.com/dotnet/machinelearning into issue-4120
frank-dong-ms Oct 2, 2019
1c71e99
Make default constructor of OnnxSequenceType attribute obsolete
frank-dong-ms Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Microsoft.ML.OnnxTransformer/OnnxSequenceType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,10 @@ public sealed class OnnxSequenceTypeAttribute : DataViewTypeAttribute
{
private Type _elemType;

/// <summary>
/// Create a sequence type.
/// </summary>
// Make default constructor obsolete.
// Use default constructor will left the _elemType field empty and cause exception in methods using _elemType.
// User will receive compile error when try to use [OnnxSequenceType] attribute directly without specify sequence type
[Obsolete("Please specify sequence type when use OnnxSequenceType Attribute", true)]
public OnnxSequenceTypeAttribute()
{
}
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.ML.Tests/OnnxSequenceTypeWithAttributesTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ public void OnnxSequenceTypeWithColumnNameAttributeTest()

}
}
}
}