Modified the project to support running of TensorFlow on GPU on Windows.#4270
Merged
codemzs merged 4 commits intodotnet:masterfrom Oct 2, 2019
bpstark:addGPU
Merged
Modified the project to support running of TensorFlow on GPU on Windows.#4270codemzs merged 4 commits intodotnet:masterfrom bpstark:addGPU
codemzs merged 4 commits intodotnet:masterfrom
bpstark:addGPU
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4270 +/- ##
==========================================
+ Coverage 74.46% 74.47% +<.01%
==========================================
Files 877 877
Lines 153660 153660
Branches 16828 16828
==========================================
+ Hits 114428 114442 +14
+ Misses 34496 34484 -12
+ Partials 4736 4734 -2
|
Codecov Report
@@ Coverage Diff @@
## master #4270 +/- ##
=========================================
Coverage ? 74.47%
=========================================
Files ? 877
Lines ? 153660
Branches ? 16828
=========================================
Hits ? 114442
Misses ? 34484
Partials ? 4734
|
codemzs
reviewed
Oct 2, 2019
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.ML.Onnx.TestModels" Version="$(MicrosoftMLOnnxTestModelsVersion)" /> | ||
| <PackageReference Include="SciSharp.TensorFlow.Redist" Version="1.14.0" /> |
Member
There was a problem hiding this comment.
1.14.0" [](start = 68, length = 7)
1.14.0" [](start = 68, length = 7)
Can this be made a variable in \machinelearning\build\Dependencies.props #Resolved
codemzs
reviewed
Oct 2, 2019
| { | ||
| int samples = 0; | ||
|
|
||
|
|
codemzs
reviewed
Oct 2, 2019
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.ML.Onnx.TestModels" Version="$(MicrosoftMLOnnxTestModelsVersion)" /> | ||
| <PackageReference Include="SciSharp.TensorFlow.Redist-Windows-GPU" Version="1.14.0" /> |
Member
There was a problem hiding this comment.
1.14.0 [](start = 80, length = 6)
1.14.0 [](start = 80, length = 6)
Can this be made a variable in \machinelearning\build\Dependencies.props #Resolved
codemzs
reviewed
Oct 2, 2019
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.ML.TestModels" Version="$(MicrosoftMLTestModelsPackageVersion)" /> | ||
| <PackageReference Include="SciSharp.TensorFlow.Redist" Version="1.14.0" /> |
Member
There was a problem hiding this comment.
Version="1.14.0" /> [](start = 59, length = 19)
Version="1.14.0" /> [](start = 59, length = 19)
Can this be made a variable in \machinelearning\build\Dependencies.props #Resolved
codemzs
reviewed
Oct 2, 2019
| <PackageReference Include="Microsoft.ML.Onnx.TestModels" Version="$(MicrosoftMLOnnxTestModelsVersion)" /> | ||
| <PackageReference Include="Microsoft.ML.TestDatabases" Version="$(MicrosoftMLTestDatabasesPackageVersion)" /> | ||
| <PackageReference Include="Microsoft.ML.TestModels" Version="$(MicrosoftMLTestModelsPackageVersion)" /> | ||
| <PackageReference Include="SciSharp.TensorFlow.Redist" Version="1.14.0" /> |
Member
There was a problem hiding this comment.
t" Version="1.14.0" /> [](start = 56, length = 22)
t" Version="1.14.0" /> [](start = 56, length = 22)
Can this be made a variable in \machinelearning\build\Dependencies.props #Resolved
added 4 commits
October 1, 2019 17:18
Removed all dependencies of TensorFlow redist from the source projects, and instead added the dependency to the Sample project. Created separate sample project for GPU examples since gpu tensorflow requires cuda, which may not be available on all machines, so it needs to be a separate project. Added documentation for setup as there is now some requirements.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all dependencies of TensorFlow redist from the source projects,
and instead added the dependency to the Sample project.
Created separate sample project for GPU examples since gpu tensorflow requires cuda,
which may not be available on all machines, so it needs to be a separate
project.
Added documentation for setup as there is now some setup requirements to use this API.
In testing on the large flowers data set I was able to see a large improvement in speed, from taking ~720 seconds to train to taking ~156 seconds.
Fixes #4269
Addresses part of the issue in #86