Conversation
eerhardt
reviewed
Sep 27, 2019
eerhardt
reviewed
Sep 27, 2019
Member
eerhardt
reviewed
Sep 27, 2019
eerhardt
reviewed
Sep 27, 2019
eerhardt
reviewed
Sep 27, 2019
eerhardt
reviewed
Sep 27, 2019
eerhardt
reviewed
Sep 27, 2019
eerhardt
reviewed
Sep 30, 2019
eerhardt
reviewed
Sep 30, 2019
eerhardt
reviewed
Sep 30, 2019
eerhardt
reviewed
Sep 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #4260 +/- ##
==========================================
- Coverage 74.48% 74.48% -0.01%
==========================================
Files 877 878 +1
Lines 153663 153688 +25
Branches 16828 16830 +2
==========================================
+ Hits 114457 114469 +12
- Misses 34474 34479 +5
- Partials 4732 4740 +8
|
Nucs
reviewed
Oct 1, 2019
|
After this PR will be merged, If needed - I'll add performant support for conversion between types instead of throwing |
eerhardt
reviewed
Oct 1, 2019
eerhardt
reviewed
Oct 1, 2019
eerhardt
approved these changes
Oct 1, 2019
Member
eerhardt
left a comment
There was a problem hiding this comment.
Just 2 comments. After those are addressed I believe this can be merged. Nice work.
eerhardt
reviewed
Oct 1, 2019
eerhardt
approved these changes
Oct 1, 2019
256f9e9 to
ecbfc65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output tensors from graph are being copied from unamanaged to managed memory and every time a new buffer is created. Performance will be better if we reuse buffer when it's possible.
Improve performance by replacing ToArray method in Tensor class with extension methods: ToScalar, ToSpan and ToArray