Skip to content

Fix NgramExtractingTransformer GetSlotNames to not allocate a new delegate on every invoke. #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 1 commit into from
Sep 26, 2019
Merged

Fix NgramExtractingTransformer GetSlotNames to not allocate a new delegate on every invoke. #4247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/Microsoft.ML.Transforms/Text/NgramTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,17 +544,14 @@ private void GetSlotNames(int iinfo, int size, ref VBuffer<ReadOnlyMemory<char>>
Host.Assert(n >= 0);

// Get the unigrams composing the current n-gram.
ComposeNgramString(ngram, n, sb, keyCount,
unigramNames.GetItemOrDefault);
ComposeNgramString(ngram, n, sb, keyCount, in unigramNames);
dstEditor.Values[slot] = sb.ToString().AsMemory();
}

dst = dstEditor.Commit();
}

private delegate void TermGetter(int index, ref ReadOnlyMemory<char> term);

private void ComposeNgramString(uint[] ngram, int count, StringBuilder sb, int keyCount, TermGetter termGetter)
private void ComposeNgramString(uint[] ngram, int count, StringBuilder sb, int keyCount, in VBuffer<ReadOnlyMemory<char>> terms)
{
Host.AssertValue(sb);
Host.AssertValue(ngram);
Expand All @@ -572,7 +569,7 @@ private void ComposeNgramString(uint[] ngram, int count, StringBuilder sb, int k
sb.Append("*");
else
{
termGetter((int)unigram - 1, ref term);
term = terms.GetItemOrDefault((int)unigram - 1);
sb.AppendMemory(term);
}
}
Expand Down