Changed Image classification API to accept Image as VBuffer<byte> by harshithapv · Pull Request #4242 · dotnet/machinelearning

harshithapv · 2019-09-23T17:41:14Z

Changed Image classification API to accept Image as V Buffer. Also, added a few optimizations to re-use the buffer for performance gains.
So we can do the best job, please check:

fixes #4153

dnfclas · 2019-09-23T17:41:32Z

All CLA requirements met.

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs

...icrosoft.ML.Samples/Dynamic/ImageClassification/ResnetV2101TransferLearningTrainTestSplit.cs

docs/samples/Microsoft.ML.Samples/Program.cs

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs

codemzs · 2019-09-29T01:47:18Z

Please revert this file, i.e git checkout upstream master filepath

Refers to: docs/samples/Microsoft.ML.Samples/Program.cs:32 in ae2ac0d. [](commit_id = ae2ac0d, deletion_comment = False)

...icrosoft.ML.Samples/Dynamic/ImageClassification/ResnetV2101TransferLearningTrainTestSplit.cs

test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs

src/Microsoft.ML.ImageAnalytics/Microsoft.ML.ImageAnalytics.csproj

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

src/Microsoft.ML.ImageAnalytics/ExtensionsCatalog.cs

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs

codemzs · 2019-10-03T01:38:30Z

            verWeCanReadBack: 0x00010002,

increment these versions since you are changing model format and then when deserializing the model check if the model was written with an older version or new version and based on that try to deserialize indicator for image type. #Resolved

Refers to: src/Microsoft.ML.ImageAnalytics/ImageLoader.cs:183 in 20d6660. [](commit_id = 20d6660, deletion_comment = False)

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

…comments.

...icrosoft.ML.Samples/Dynamic/ImageClassification/ResnetV2101TransferLearningTrainTestSplit.cs

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs

src/Microsoft.ML.ImageAnalytics/Microsoft.ML.ImageAnalytics.csproj

tools-local/Microsoft.ML.StableApi/Microsoft.ML.StableApi.csproj

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

codemzs

yaeldekel · 2019-10-07T07:18:52Z

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

 // See the LICENSE file in the project root for more information.

 using System;
+using System.Collections.Concurrent;


Concurrent [](start = 25, length = 10)

This and System.Runtime.InteropServices are not used, please remove them.
Also, System.Diagnostics.Contracts should not be used, on line 328 you have Contract.Assert instead of Contracts.Assert.

yaeldekel · 2019-10-07T07:32:00Z

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs


            ImageFolder = ctx.LoadStringOrNull();
+           if (ctx.Header.ModelVerWritten >= 0x00010003) // do a version check
+                UseImageType = ctx.Reader.ReadBoolean();


ReadBoolean [](start = 42, length = 11)

Please use ReadBoolByte instead.

yaeldekel · 2019-10-07T07:33:43Z

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

-                verWeCanReadBack: 0x00010002,
+                verWrittenCur: 0x00010003, // Added support for output type as byte array
+                verReadableCur: 0x00010003,
+                verWeCanReadBack: 0x00010003,


0x00010003 [](start = 34, length = 10)

This should still be 0x00010002, since you are taking care of backwards compatibility in line 138.

yaeldekel · 2019-10-07T07:36:37Z

src/Microsoft.ML.ImageAnalytics/ImageLoader.cs

+            private static bool TryLoadDataIntoBuffer(string path, ref VBuffer<byte> imgData, byte[] readBuffer)
+            {
+                int count = -1;
+                int bytesread = -1;


These two don't need to be defined in advance.

CESARDELATORRE · 2019-10-07T19:28:02Z

...icrosoft.ML.Samples/Dynamic/ImageClassification/ResnetV2101TransferLearningTrainTestSplit.cs

                imagesForPredictions, false);

+            byte[] imgBytes = File.ReadAllBytes(testImages.First().ImagePath);
+            VBuffer<Byte> imgData = new VBuffer<byte>(imgBytes.Length, imgBytes);


It doesn't look like this in-memory image is being used for the Prediction when using the PredictionEngine, right?
In fact, looks like this object 'imgData' is not used later on?

We need to have and test Predictions by providing the in-memory image instead of file paths.
I cannot find such a code.

…Added functionality to use resnet_v2_50 model. Added learning rate scheduling for CIFAR-10 dataset.

yaeldekel reviewed Sep 24, 2019

View reviewed changes

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs Outdated Show resolved Hide resolved

yaeldekel reviewed Sep 24, 2019

View reviewed changes

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs Outdated Show resolved Hide resolved

yaeldekel reviewed Sep 24, 2019

View reviewed changes

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs Outdated Show resolved Hide resolved

yaeldekel reviewed Sep 24, 2019

View reviewed changes

...icrosoft.ML.Samples/Dynamic/ImageClassification/ResnetV2101TransferLearningTrainTestSplit.cs Outdated Show resolved Hide resolved

yaeldekel reviewed Sep 24, 2019

View reviewed changes

docs/samples/Microsoft.ML.Samples/Program.cs Outdated Show resolved Hide resolved

yaeldekel reviewed Sep 26, 2019

View reviewed changes

src/Microsoft.ML.Dnn/ImageClassificationTransform.cs Show resolved Hide resolved