Fix memory leak in TensorflowTransform#4223
Merged
codemzs merged 3 commits intodotnet:masterfrom Sep 29, 2019
Merged
Conversation
eerhardt
reviewed
Sep 17, 2019
eerhardt
reviewed
Sep 17, 2019
Oceania2018
approved these changes
Sep 18, 2019
|
|
eerhardt
reviewed
Sep 26, 2019
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
I think this approach is fine for now. But as I discussed with @codemzs, we need to solve this issue all up in ML.NET. See #906 (which was closed for some reason?).
TensorFlow and Onnx transformers both have native resources that need to be cleaned up. And with #4157 we are adding even more transformers that require native resource clean up. Relying on Finalizers to do this cleanup is not ideal. Instead, we should allow users to dispose transformers that need disposing without relying on the Finalizer to do it.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two memory leaks:
This fixes #4134