Skip to content

Internalize tensorflow API and sanity check APIs from Microsoft.ML.Tensorflow nuget #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codemzs merged 1 commit into from
Jul 1, 2019
Merged

Internalize tensorflow API and sanity check APIs from Microsoft.ML.Tensorflow nuget #3936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.ML.TensorFlow/TensorFlow/TensorflowUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

namespace Microsoft.ML.Transforms.TensorFlow
{
public static class TensorFlowUtils
internal static class TensorFlowUtils
{
/// <summary>
/// Key to access operator's type (a string) in <see cref="DataViewSchema.Column.Annotations"/>.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.TensorFlow/TensorFlowModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public TensorFlowEstimator ScoreTensorFlowModel(string[] outputColumnNames, stri
/// <remarks>
/// The support for retraining is experimental.
/// </remarks>
public TensorFlowEstimator RetrainTensorFlowModel(
internal TensorFlowEstimator RetrainTensorFlowModel(
Copy link
Contributor

@artidoro artidoro Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a pretty useful feature to have: being able to retrain existing graphs. Why do you want to remove it?

Copy link
Member Author

@codemzs codemzs Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @eerhardt "TensorFlowModel contains the most important method of the component - ScoreTensorFlowModel. However, it also contains a RetrainTensorFlowModel whose documentation say it is "experimental:...I think it is confusing to have an "experimental" API on the same class as a stable API."

We can always add it back and we are switching to TF.NET where we will enable this functionality anyways. It is easier to add things than to add then remove and modify.

Copy link
Contributor

@artidoro artidoro Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok makes sense. Maybe we could either:

  1. Write an issue about it.
  2. Add it as an extension to a preview API nuget (such as the experimental nuget)

Copy link
Member Author

@codemzs codemzs Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, i'll open an issue.

string[] outputColumnNames,
string[] inputColumnNames,
string labelColumnName,
Expand Down