Add Microsoft.Extensions.ML integration package. by eerhardt · Pull Request #3827 · dotnet/machinelearning

eerhardt · 2019-06-05T01:01:01Z

This package makes it easier to use ML.NET with app models that support Microsoft.Extensions - i.e. ASP.NET and Azure Functions.

Specifically it contains functionality for:

Dependency Injection
Pooling PredictionEngines
Reloading models when the file or URI has changed
Hooking ML.NET logging to Microsoft.Extensions.Logging

Fix #3239

cc @glennc - Note that the only major change I made to your code was to remove the IPredictionEnginePoolBuilder interface in favor of using a simple class instead.

After this is merged to master, we can remove the features/IntegrationPackage branch.

This package makes it easier to use ML.NET with app models that support Microsoft.Extensions - i.e. ASP.NET and Azure Functions. Specifically it contains functionality for: - Dependency Injection - Pooling PredictionEngines - Reloading models when the file or URI has changed - Hooking ML.NET logging to Microsoft.Extensions.Logging Fix dotnet#3239

Format the code so lines aren't so long. Remove unnecessary IPredictionEnginePoolBuilder interface, and just use a regular class.

src/Microsoft.Extensions.ML/Builder/BuilderExtensions.cs

src/Microsoft.Extensions.ML/Builder/PredictionEnginePoolBuilder.cs

src/Microsoft.Extensions.ML/MLContextOptions.cs

src/Microsoft.Extensions.ML/ModelReloadToken.cs

src/Microsoft.Extensions.ML/PoolLoader.cs

src/Microsoft.Extensions.ML/PredictionEnginePoolPolicy.cs

src/Microsoft.Extensions.ML/ServiceCollectionExtensions.cs

src/Microsoft.Extensions.ML/ModelLoaders/UriModelLoader.cs

codemzs

Looks good except for @wschin 's comment on MLContext wrapping. Please resolve with him before checking in.

test/Microsoft.Extensions.ML.Tests/FileLoaderTests.cs

Rename MLContextOptions to MLOptions. Make MLContext lazy loaded, so callers can provide their own. Use the loaded model in the test.

eerhardt added 2 commits June 4, 2019 18:34

Add XML doc comments.

2e6f38e

Format the code so lines aren't so long. Remove unnecessary IPredictionEnginePoolBuilder interface, and just use a regular class.

eerhardt requested review from artidoro, codemzs, glennc, wschin and yaeldekel June 5, 2019 01:01