Skip to content

Add Cancellation checkpoint in Normalizer transfomer. #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfilipi merged 2 commits into from
Mar 22, 2019
Merged

Add Cancellation checkpoint in Normalizer transfomer. #3062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f78f22
Add Cancellation checkpoint in Normalizer transfomer.
codemzs Mar 22, 2019
aa7357c
revert.
codemzs Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.ML.Data/Transforms/Normalizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ internal static NormalizingTransformer Train(IHostEnvironment env, IDataView dat

while (cursor.MoveNext())
{
env.CheckAlive();
// If the row has bad values, the good values are still being used for training.
// The comparisons in the code below are arranged so that NaNs in the input are not recorded.
// REVIEW: Should infinities and/or NaNs be filtered before the normalization? Should we not record infinities for min/max?
Expand Down