Update of FeatureContributionCalculation to new API#1847
Merged
artidoro merged 50 commits intodotnet:masterfrom Dec 20, 2018
Merged
Update of FeatureContributionCalculation to new API#1847artidoro merged 50 commits intodotnet:masterfrom
artidoro merged 50 commits intodotnet:masterfrom
Conversation
rogancarr
reviewed
Dec 7, 2018
rogancarr
reviewed
Dec 7, 2018
rogancarr
reviewed
Dec 7, 2018
rogancarr
reviewed
Dec 7, 2018
rogancarr
reviewed
Dec 7, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
artidoro
commented
Dec 7, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
rogancarr
reviewed
Dec 7, 2018
Contributor
rogancarr
left a comment
There was a problem hiding this comment.
I did a non-technical pass over to look at usability. Overall, this looks good! Mostly, I'd like to make sure we can use it in pipelines and that we have tests that cover the options and the implementations. (Although maybe implementation tests can be a separate PR.)
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
f969628 to
74d6581
Compare
artidoro
commented
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Dec 11, 2018
src/Microsoft.ML.Data/Scorers/FeatureContributionCalculatingTransformer.cs
Outdated
Show resolved
Hide resolved
Ivanidzo4ka
reviewed
Dec 11, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/FeatureContributionCalculationTransform.cs
Outdated
Show resolved
Hide resolved
Contributor
I think we tend to put results of output into comments for the file. #Resolved Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/FeatureContributionCalculationTransform.cs:87 in a62a510. [](commit_id = a62a510, deletion_comment = False) |
Ivanidzo4ka
reviewed
Dec 11, 2018
Ivanidzo4ka
reviewed
Dec 11, 2018
…nals, and test fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1791.
As this is a WIP PR, I am still completing the work, but I would really appreciate your feedback on what I have done so far.
In this PR:
Will do in a separate PR: