Skip to content

Prevent learning pipeline from adding null transform model to the pipeline #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codemzs merged 3 commits into from
May 15, 2018
Merged

Prevent learning pipeline from adding null transform model to the pipeline #154

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b36f5b6
fix.
codemzs May 14, 2018
1b225f0
Add test.
codemzs May 15, 2018
bbe39e4
PR feedback.
codemzs May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Microsoft.ML/LearningPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,9 @@ public PredictionModel<TInput, TOutput> Train<TInput, TOutput>()

if (transformModels.Count > 0)
{
transformModels.Insert(0,lastTransformModel);
if (lastTransformModel != null)
transformModels.Insert(0, lastTransformModel);

@Ivanidzo4ka Ivanidzo4ka May 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transformModels [](start = 24, length = 15)

would be nice to add test coverage

@codemzs codemzs May 15, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


var modelInput = new Transforms.ModelCombiner
{
Models = new ArrayVar<ITransformModel>(transformModels.ToArray())
Expand Down