Skip to content

Decimal separator different in different windows language pack #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Anipik wants to merge 2 commits into from
Closed

Decimal separator different in different windows language pack #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7c9b29
fixing tests for non-english windwos
Anipik May 10, 2018
3281b3b
Feedback addressed
Anipik May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Microsoft.ML.TestFramework/BaseTestBaseline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ protected bool CheckEqualityFromPathsCore(string relPath, string basePath, strin

private static void GetNumbersFromFile(ref string firstString, ref string secondString, decimal precision)
{
Regex _matchNumer = new Regex(@"\b[0-9]+\.?[0-9]*\b", RegexOptions.IgnoreCase | RegexOptions.Compiled);
Regex _matchNumer = new Regex(@"\b[0-9]+[\.,]?[0-9]*\b", RegexOptions.IgnoreCase | RegexOptions.Compiled);
Copy link
Member

@eerhardt eerhardt May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other decimal separators in other languages that we should care about?. I think using CurrentCulture.NumberFormatInfo was a good idea.

MatchCollection firstCollection = _matchNumer.Matches(firstString);
MatchCollection secondCollection = _matchNumer.Matches(secondString);

Expand Down