Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Core/ComponentModel/ComponentCatalog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ private static bool ShouldSkipPath(string path)
case "libiomp5md.dll":
case "libvw.dll":
case "matrixinterf.dll":
case "Microsoft.ML.neuralnetworks.gpucuda.dll":
case "Microsoft.ML.mklimports.dll":
case "Microsoft.MachineLearning.neuralnetworks.gpucuda.dll":
case "Microsoft.MachineLearning.mklimports.dll":
case "microsoft.research.controls.decisiontrees.dll":
case "Microsoft.ML.neuralnetworks.sse.dll":
case "neuraltreeevaluator.dll":
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ protected override void ComputeTrainingStatistics(IChannel ch, FloatLabelCursor.
}
catch (DllNotFoundException)
{
throw ch.ExceptNotSupp("The MKL library (Microsoft.ML.MklImports.dll) or one of its dependencies is missing.");
throw ch.ExceptNotSupp("The MKL library (Microsoft.MachineLearning.MklImports.dll) or one of its dependencies is missing.");
}

Float[] stdErrorValues = new Float[numParams];
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Transforms/WhiteningTransform.cs
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ private static Float DotProduct(Float[] a, int aOffset, Float[] b, int[] indices

private static class Mkl
{
private const string DllName = "Microsoft.ML.MklImports.dll";
private const string DllName = "Microsoft.MachineLearning.MklImports.dll";

@TomFinley TomFinley May 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft.MachineLearning [](start = 44, length = 25)

Is this related to the issue raised?

Given that we decided on Microsoft.ML vs. the more verbose Microsoft.MachineLearning, should not that DLL change its name, rather than the other way around? #Resolved

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same question but I also feel this should be made as a separate change and we should open an issue for this.


In reply to: 187159434 [](ancestors = 187159434)


public enum Layout
{
Expand Down
Loading