-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle PInvoke analysis similar to other methods #2091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
reviewed
Jun 14, 2021
vitek-karas
reviewed
Jun 14, 2021
vitek-karas
reviewed
Jun 14, 2021
vitek-karas
approved these changes
Jun 16, 2021
test/Mono.Linker.Tests.Cases/Interop/PInvoke/Warnings/ComPInvokeWarning.cs
Show resolved
Hide resolved
vitek-karas
reviewed
Jun 16, 2021
test/Mono.Linker.Tests.Cases/Interop/PInvoke/Warnings/ComPInvokeWarning.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* PInvoke fix * FB * FB * FB2 Commit migrated from dotnet/linker@fb9ef5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
PInvoke
analysis similar to other methods as discussed in issue #1989.callsite
as opposed to for thePInvoke
call itself. We do this by moving the analysis toMethodBodyScanner
andReflectionMethodBodyScanner
PInvokes
(the ones that we generate warnings) have an implicit relationship with built-in COM interop support. Specifically, IsComInterop method in the linker tries to match the logic in MarshalInfo::MarshalInfo. This means that whenBuiltInComInteropSupport
property is false (netcore
app default), dangerousPInvokes
will not work. Created a doc bug to track this.ComPInvokeWarning
test to now check for warnings from the call sitesPlan regarding the OOB library warnings