-
Notifications
You must be signed in to change notification settings - Fork 128
Update to target .NET5 framework #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
720c4d9
7ec2c57
d0a2640
6054b96
d2bbb1b
89ebff9
3448862
f301889
4e99b2f
3f763c7
5ebfc8e
7541efe
74c2f45
4bf51e1
b2730e3
7a56194
c0b34d8
2704874
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| <PropertyGroup> | ||
| <!-- Keep these in sync with _ILLinkTasksTFM in Sdk.props. --> | ||
| <!-- Keep the netcoreapp TFM in sync with the Mono.Linker.csproj condition below. --> | ||
| <TargetFrameworks>netcoreapp3.0;net472</TargetFrameworks> | ||
| <TargetFrameworks>net5.0;net472</TargetFrameworks> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I recommend to use an msbuild property for the used .NETCoreApp version to keep changes as small as possible in the future.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea - we should probably do that as a follow-up - the plan is to try to backport this to 5.0 release, so I would like to keep the changes to minimum. |
||
| <EnableDefaultCompileItems>false</EnableDefaultCompileItems> | ||
| <Description>MSBuild tasks for running the IL Linker</Description> | ||
| <LangVersion>latest</LangVersion> | ||
|
|
@@ -36,7 +36,7 @@ | |
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="../linker/Mono.Linker.csproj" PrivateAssets="All" Condition=" '$(TargetFramework)' == 'netcoreapp3.0' " /> | ||
| <ProjectReference Include="../linker/Mono.Linker.csproj" PrivateAssets="All" Condition=" '$(TargetFramework)' == 'net5.0' " /> | ||
| <PackageReference Condition="'$(UseCecilPackage)' == 'true'" Include="Mono.Cecil" Version="$(MonoCecilVersion)" PrivateAssets="All" Publish="True" /> | ||
| <ProjectReference Condition="'$(UseCecilPackage)' != 'true'" Include="../../external/cecil/Mono.Cecil.csproj" PrivateAssets="All" /> | ||
| </ItemGroup> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -235,7 +235,7 @@ public string ILLinkPath { | |
|
|
||
| var taskDirectory = Path.GetDirectoryName (Assembly.GetExecutingAssembly ().Location); | ||
| // The linker always runs on .NET Core, even when using desktop MSBuild to host ILLink.Tasks. | ||
| _illinkPath = Path.Combine (Path.GetDirectoryName (taskDirectory), "netcoreapp3.0", "illink.dll"); | ||
| _illinkPath = Path.Combine (Path.GetDirectoryName (taskDirectory), "net5.0", "illink.dll"); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The proposed msbuild property for the used .NETCoreApp version can also flow into this file by supplying the constant in the project file. |
||
| return _illinkPath; | ||
| } | ||
| set => _illinkPath = value; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <linker> | ||
| <assembly fullname="test, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null"> | ||
| <type fullname="Mono.Linker.Tests.Cases.DynamicDependencies.DynamicDependencyFromAttributeXml"> | ||
| <method name="DependencyToUnusedMethod"> | ||
| <attribute fullname="System.Diagnostics.CodeAnalysis.DynamicDependencyAttribute" assembly="Mono.Linker.Tests.Cases.Expectations"> | ||
| <argument>UnusedMethod</argument> | ||
| </attribute> | ||
| </method> | ||
| </type> | ||
| </assembly> | ||
| </linker> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <linker> | ||
| <assembly fullname="library, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null"> | ||
| <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> | ||
| <argument>ILLink</argument> | ||
| <argument>IL2072</argument> | ||
| <property name="Scope">member</property> | ||
| <property name="Target">M:Mono.Linker.Tests.Cases.Warnings.WarningSuppression.Dependencies.TriggerWarnings_Lib.Main</property> | ||
| </attribute> | ||
| <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> | ||
| <argument>ILLink</argument> | ||
| <argument>IL2072</argument> | ||
| <property name="Scope">member</property> | ||
| <property name="Target">M:Mono.Linker.Tests.Cases.Warnings.WarningSuppression.Dependencies.TriggerWarnings_Lib.NestedType.Warning3</property> | ||
| </attribute> | ||
| <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> | ||
| <argument>ILLink</argument> | ||
| <argument>IL2072</argument> | ||
| <property name="Scope">member</property> | ||
| <property name="Target">M:Mono.Linker.Tests.Cases.Warnings.WarningSuppression.Dependencies.TriggerWarnings_Lib.NestedType.Warning4``1(System.Collections.Generic.List{``0}@)</property> | ||
| </attribute> | ||
| <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> | ||
| <argument>ILLink</argument> | ||
| <argument>IL2072</argument> | ||
| <property name="Scope">member</property> | ||
| <property name="Target">M:Mono.Linker.Tests.Cases.Warnings.WarningSuppression.Dependencies.TriggerWarnings_Lib.Warning1</property> | ||
| </attribute> | ||
| <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> | ||
| <argument>ILLink</argument> | ||
| <argument>IL2072</argument> | ||
| <property name="Scope">member</property> | ||
| <property name="Target">M:Mono.Linker.Tests.Cases.Warnings.WarningSuppression.Dependencies.TriggerWarnings_Lib.get_Warning2</property> | ||
| </attribute> | ||
| </assembly> | ||
| </linker> |
Uh oh!
There was an error while loading. Please reload this page.