Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JCW_ONLY_TYPE_NAMES #58

Closed
jonpryor opened this issue Jul 25, 2016 · 0 comments · Fixed by #60
Closed

Remove JCW_ONLY_TYPE_NAMES #58

jonpryor opened this issue Jul 25, 2016 · 0 comments · Fixed by #60
Assignees
@atsushieno

Comments

@jonpryor
Copy link
Member

jonpryor commented Jul 25, 2016 •
edited
Loading

Many of the types within src/Xamarin.Android.NamingCustomAttributes use JCW_ONLY_TYPE_NAMES to control member visibility.

This is the wrong way to control member visibility.

Instead, all the Xamarin.Android.NamingCustomAttributes types should be partial types, not public by default, and contain only naming-related functionality.

Android-specific functionality not related to type names -- i.e. not used in this repo -- should be moved into the xamarin-android repo.
@atsushieno atsushieno self-assigned this Jul 25, 2016
atsushieno added a commit to atsushieno/java.interop that referenced this issue Aug 2, 2016
@atsushieno
Reorganize Xamarin.Android.NamingCustomAttributes.shproj (i.e. Attrib…
5583d26 
…utes)

context: dotnet#58

We have complicated module interdependency between this and xamarin-android,
so this set of changes is to fix the situation.

So far, here is the changeset summary:

- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
  use in this repository. It will be shrinked in the later commits to have
  only required bits in Java/Interop.
atsushieno added a commit to atsushieno/xamarin-android that referenced this issue Aug 2, 2016
@atsushieno
Reorganize Xamarin.Android.NamingCustomAttributes.
04fe9c0 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
atsushieno added a commit to atsushieno/xamarin-android that referenced this issue Aug 2, 2016
@atsushieno
Reorganize Xamarin.Android.NamingCustomAttributes.
fc3226a 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
atsushieno added a commit to atsushieno/java.interop that referenced this issue Aug 2, 2016
@atsushieno
Remove extraneous attribute members.
bd53e10 
As part of dotnet#58

We are not going to need attribute members on this shared project anymore.
Those type members should be in Xamarin.Android.NamingCustomAttributes instead.
atsushieno added a commit to atsushieno/xamarin-android that referenced this issue Aug 2, 2016
@atsushieno
Reorganize Xamarin.Android.NamingCustomAttributes.
cd97b35 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
atsushieno added a commit to atsushieno/xamarin-android that referenced this issue Aug 2, 2016
@atsushieno
Reorganize Xamarin.Android.NamingCustomAttributes.
56045ef 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
This was referenced Aug 2, 2016
Merged
Merged
jonpryor pushed a commit that referenced this issue Aug 4, 2016
@atsushieno @jonpryor
[Java.Interop.NamingCustomAttributes] Reorganize attributes (#60)
b58416a 
Context: #58

Rename `Xamarin.Android.NamingCustomAttributes.shproj` to
`Java.Interop.NamingCustomAttributes.shproj`, and "simplify" the
custom attributes so that they don't contain any members that aren't
needed within the Java.Interop repo. Through (gratuitous?) use of
`partial` classes, the xamarin-android repo can add additional
members to the custom attribute types, thus remove a
"hard dependency" between the two git repos. For example, the
`Android.App.ActivityAttribute.AllowEmbedded` property is only needed
for `AndroidManifest.xml` generation within the xamarin-android repo,
and is not needed in the Java.Interop repo, so remove it.

The xamarin-android repo will gain a new
`Xamarin.Android.NamingCustomAttributes.shproj` shared project which
will contain all of the Android-specific members that were formerly
in this repo.
atsushieno added a commit to atsushieno/xamarin-android that referenced this issue Aug 4, 2016
@atsushieno
Reorganize Xamarin.Android.NamingCustomAttributes.
7e26d67 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
atsushieno added a commit to atsushieno/xamarin-android that referenced this issue Aug 5, 2016
@atsushieno
Reorganize Xamarin.Android.NamingCustomAttributes.
cd7c541 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
jonpryor pushed a commit to dotnet/android that referenced this issue Aug 8, 2016
@atsushieno @jonpryor
Reorganize Xamarin.Android.NamingCustomAttributes. (#139)
ff1c80d 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
radekdoulik pushed a commit to radekdoulik/xamarin-android that referenced this issue Aug 12, 2016
@atsushieno @radekdoulik
Reorganize Xamarin.Android.NamingCustomAttributes. (dotnet#139)
6bbadd5 
context: dotnet/java-interop#58
dependent on: atsushieno/java.interop@5583d26

Copypasting the changes on Java.Interop

	We have complicated module interdependency between this and xamarin-android,
	so this set of changes is to fix the situation.

	So far, here is the changeset summary:

	- Xamarin.Android.NamingCustomAttributes.shproj is moved to xamarin-android
	- there will be new Java.Interop.NamingCustomAttributes.shproj which is for
	  use in this repository. It will be shrinked in the later commits to have
	  only required bits in Java/Interop.

Now Xamarin.Android.sln has two NamingCustomAttributes.shproj: one for
imported and then slightly stripped version of the original shared project
in xamarin-android, and renamed and then significantly stripped version
in Java.Interop.

Build adjustment comes next.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atsushieno atsushieno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorganize attributes atsushieno/java.interop
2 participants
@atsushieno @jonpryor