Replace legacy packages with VS insertion packages for non-shipping version numbers. #9059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
reviewed
Nov 11, 2020
| <Sha>c0d88e97c24130c78429dbee4444e4941b1c26f6</Sha> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.WindowsDesktop.App" Version="6.0.0-alpha.1.20559.4" CoherentParentDependency="Microsoft.NET.Sdk"> | ||
| <Dependency Name="VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0" Version="6.0.0-alpha.1.20559.4" CoherentParentDependency="Microsoft.NET.Sdk"> |
Member
There was a problem hiding this comment.
The added dependencies need to be added to dotnet/sdk for coherency purposes, if they do not already exist.
Member
Author
There was a problem hiding this comment.
I'll open a PR to add the new dependencies to dotnet/sdk.
mmitche
reviewed
Nov 11, 2020
Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
mmitche
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotnet/runtime#38457 and dotnet/windowsdesktop#909 we're removing the Microsoft.NETCore.App.Internal and Microsoft.WindowsDesktop.App legacy packages respectively. This PR moves the usage in dotnet/installer to use the VS insertion packages to get the non-shipping version numbers similar to the usage for ASP.NET Core.