Set the CrossBuild property instead of the CROSSCOMPILE environment variable #18915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run installer-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run installer-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run installer-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
mmitche
approved these changes
Mar 11, 2024
akoeplinger
approved these changes
Mar 11, 2024
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
I wonder if we still need #18294?
Member
Author
|
We might still need it as I don't remember how installer hooks up their crossbuilds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting
CROSSCOMPILE, we're forcing all CoreCLR build steps to use the rootfs. We should pass theCrossBuildproperty instead which will allow the dotnet/runtime build targets to correctly specify which build steps will use the rootfs and which ones should use the host.Fixes dotnet/source-build#3698