-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS RIDs to code which adds ILAsm/ILDAsm dependency #17385
Conversation
Do you want this in 8.0? If so, I would recommend targeting release/8.0 and it will automatically flow into main. If you target main you will have to manually backport it. |
I have no strong feelings RE 8.0, my overall work is part of a wider VMR-everything goal for 9.0. I kinda assumed we were too late for anything in 8.0 now anyway. If there's still some 8.0 process available, and I won't have to sit through a 60 minute Tactics meeting to plead my case, I can re-target |
Feel free to retarget - we don't need approval for this change. |
ad29acf
to
482d83b
Compare
|
correct. |
CI failure:
I see this package/version is only available in internal feeds. @mmitche - do we not publish the artifacts we push to nuget in any public azdo feeds? How do we reference these without getting flagged by CG for accessing non-azdo feeds? |
Yeah, I'm not sure I fully get how versioning works in the context of the VMR, will need someone source-buildy to help me understand why that's failing (also why it's adding the dependency at all when running on CentOS - surely the point of all that logic is to only depend on architecture-relevant versions of the package, not all of them ever?!) |
This logic has evolved overtime and that was never considered - I logged dotnet/source-build#3631 for this. Thanks for calling this out. |
src/SourceBuild/content/eng/bootstrap/buildBootstrapPreviouslySB.csproj
Outdated
Show resolved
Hide resolved
dotnet-public is the nuget mirror. The RC1 version of this is on Nuget, but because the ID has never been mirrored to dotnet-public, it wasn't ingested. I've queued https://dev.azure.com/dnceng/internal/_build/results?buildId=2271480&view=results to ingest it. |
Looks like this is green after the update merge |
Can you respond to Matt's comment #17385 (comment) first then I will merge. |
This is the 2023 flavour of the ILAsm dependency issue mentioned on dotnet/source-build#2795