Skip to content

Disable SCM queries for build #17157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Disable SCM queries for build #17157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/SourceBuild/content/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<ImportNetSdkFromRepoToolset>false</ImportNetSdkFromRepoToolset>
<_SuppressSdkImports>true</_SuppressSdkImports>
<Configuration Condition="$(Configuration) == ''">Release</Configuration>
<EnableSourceControlManagerQueries>false</EnableSourceControlManagerQueries>
Copy link
Member

@MichaelSimons MichaelSimons Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your description made me think this was only needed for the package-source-build project? Is there a reason to set it here versus the package-source-build project?

Copy link
Member Author

@mthalman mthalman Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's only needed for package-source-build. But given the intent of the property, it seemed relevant to apply it to all projects in this context to avoid potential issues in the future.

Copy link
Member

@MichaelSimons MichaelSimons Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seemed relevant to apply it to all projects in this context to avoid potential issues in the future.

That makes sense but keep in mind it won't flow into the project repo build the way it is set so it really has limited value here.

</PropertyGroup>

<Import Condition="'$(SkipArcadeSdkImport)' != 'true'" Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
Expand Down
3 changes: 1 addition & 2 deletions ...ceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/SourceBuiltArtifactsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ public class SourceBuiltArtifactsTests : SmokeTests
{
public SourceBuiltArtifactsTests(ITestOutputHelper outputHelper) : base(outputHelper) { }

// Disabling due to https://github.com/dotnet/source-build/issues/3426
//[Fact]
[Fact]
public void VerifyVersionFile()
{
string outputDir = Path.Combine(Directory.GetCurrentDirectory(), "sourcebuilt-artifacts");
Expand Down