Enable PVP flow for command-line-api #16109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
| Backport: https://github.com/dotnet/command-line-api/pull/2150 | ||
| --- | ||
| Directory.Build.props | 6 +++--- | ||
| .../System.CommandLine.Benchmarks.csproj | 4 ++-- |
Member
There was a problem hiding this comment.
To make sure I understand what is happening correctly, dotnet/command-line-api#2150 includes serveral csproj msbuild property changes that are not included in this patch. I am assuming none of those projects are source-built. Excluding them here helps keeps the patch to a minimal which decreases the likelihood of patch conflicts.
Member
Author
There was a problem hiding this comment.
Yes, exactly. I didn't patch any of the test projects nor the System.CommandLine.Suggest project since none of those are targeted by source-build. The patch also differs (in context) from the changes in dotnet/command-line-api#2150 because it is based on a much older commit of the command-line-api repo that is referenced in the VMR.
MichaelSimons
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3043
This required updating the relevant command-line-api projects to use
$(NetCurrent)(net8.0) instead ofnet7.0to avoid prebuilts. Backported changes at dotnet/command-line-api#2150.