Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around the feature band breakage for now #15380

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Work around the feature band breakage for now #15380

merged 1 commit into from
Jan 31, 2023

Conversation

lewing
Copy link
Member

@lewing lewing commented Jan 31, 2023 •
edited
Loading

main build is failing, this is needed until runtime can produce a preview branded workload. The preview 1 branch already has this change

@lewing
Copy link
Member Author

lewing commented Jan 31, 2023

see also dotnet/runtime#81398 dotnet/runtime#81399

@lewing
Copy link
Member Author

lewing commented Jan 31, 2023

and #15381

(this is chaos)

@lewing lewing mentioned this pull request Jan 31, 2023
Closed
@steveisok steveisok self-requested a review January 31, 2023 21:26
@lewing lewing merged commit 8c2c687 into main Jan 31, 2023
@lewing lewing deleted the lewing/work-feature branch January 31, 2023 21:27
@lewing lewing mentioned this pull request Jan 31, 2023
Merged
@lewing
Copy link
Member Author

lewing commented Jan 31, 2023

so now the runtime prs are blocked on this producing an sdk that looks in preview feature bands to complete branding

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-81399-merge-9dcfdb2260584d6aa3/Workloads-Webcil-Wasm.Build.NativeRebuild.Tests.FlagsChangeRebuildTests/1/console.a0ab9500.log?helixlogtype=result is clearly         [5g5f4fat.4cp] Welcome to .NET 8.0!
        [5g5f4fat.4cp] ---------------------
        [5g5f4fat.4cp] SDK Version: 8.0.100-alpha.1.23081.3 

it is an ugly chicken and egg problem

cc @dsplaisted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveisok steveisok steveisok approved these changes

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

@joeloff joeloff Awaiting requested review from joeloff

@dsplaisted dsplaisted Awaiting requested review from dsplaisted

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers

@Redth Redth Awaiting requested review from Redth

Assignees
No one assigned
Labels
Area-Workloads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewing @steveisok