Skip to content

Eliminate 7.0 source-build prebuilts #14167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbussell merged 88 commits into from
Sep 13, 2022
Merged

Eliminate 7.0 source-build prebuilts #14167

lbussell merged 88 commits into from
Sep 13, 2022

Conversation

@MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Jul 18, 2022

Draft PR to test the tarball build with the latest product changes to remove prebuilts prior to them flowing in.

@MichaelSimons MichaelSimons mentioned this pull request Jul 21, 2022
Closed
@lbussell
Copy link
Member

lbussell commented Aug 24, 2022 •
edited
Loading

The tarball should build without any 6.0 prebuilts now.

Don't merge currently, as I pulled in vstest changes proactively before the PR gets merged. The vstest change doesn't work as a patch, I think because of deleted/moved files.

@lbussell
Copy link
Member

lbussell commented Aug 25, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 25, 2022

Pull request contains merge conflicts.

@lbussell lbussell force-pushed the 7.0-zero-prebuilts branch from c9384cf to 106bec4 Compare August 25, 2022 19:12
MichaelSimons
MichaelSimons commented Sep 6, 2022
View reviewed changes
src/SourceBuild/tarball/content/repos/known-good.proj
<RepositoryReference Include="diagnostics" />
<RepositoryReference Include="llvm-project" />
<RepositoryReference Include="razor-compiler" />
<RepositoryReference Include="xliff-tasks" />
Copy link
Member Author

@MichaelSimons MichaelSimons Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making a separate PR to check in these changes since ideally this PR would be abandoned because all the patches would get backported.

@lbussell lbussell mentioned this pull request Sep 6, 2022
Merged
@MichaelSimons
Copy link
Member Author

MichaelSimons commented Sep 12, 2022

I just merged in the PR into installer that brought in a newer xliff-tasks version to eliminate it's prebuilts. I proactively merged those changes into this PR and removed the patch for it. There were two other patches backported as well that got picked up.

@lbussell lbussell marked this pull request as ready for review September 12, 2022 23:09
@lbussell lbussell requested a review from a team as a code owner September 12, 2022 23:09
@lbussell lbussell enabled auto-merge (squash) September 13, 2022 16:56
@MichaelSimons
Copy link
Member Author

MichaelSimons commented Sep 13, 2022

I can't "approve" this via the GH control because I am the author. It does LGTM.

@lbussell lbussell merged commit 8a0eb58 into dotnet:release/7.0.1xx Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crummel crummel crummel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichaelSimons @lbussell @crummel