Fix iOS/tvOS simulator builds actually being device builds, on arm64 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveisok
approved these changes
Mar 22, 2021
|
The explainer: ICU builds specify, condensed: "Build against AppleTVSimulator.sdk, minimum tvOS version 9.0" What's critical here is this combination doesn't exist. There is a separate Clang parameter for specifying tvOS simulator version. It is silently changing the specified values:
This patch fixes the build so simulator builds explicitly request a simulator version, so clang doesn't silently override the SDK to build against. |
|
Private build has passed. |
directhex
pushed a commit
that referenced
this pull request
May 13, 2022
* add valgrind job to pipeline * correct paths for valgrind script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: dotnet/runtime#50005
Indispensable: the chart on rust-lang/rust#48862