Fixed consuming CSharp interface with an inref parameter #8287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Jan 20, 2020
Comment on lines
+271
to
+277
| | TestCompilationReference (cmpl) -> | ||
| let tmp = Path.GetTempFileName() | ||
| disposals.Add({ new IDisposable with | ||
| member _.Dispose() = | ||
| try File.Delete tmp with | _ -> () }) | ||
| cmpl.EmitAsFile tmp | ||
| (([||], tmp), []), false) |
Contributor
There was a problem hiding this comment.
I take it this was just leaving stuff around?
Contributor
Author
There was a problem hiding this comment.
This is all new, so nothing was being left around before. But yes, once I create a tmp file, I need to make sure we always try to delete it on dispose.
Comment on lines
+59
to
+60
| type CompilationReference = | ||
| private |
Contributor
There was a problem hiding this comment.
nit: type private is more idiomatic
Contributor
Author
There was a problem hiding this comment.
type private makes the whole type private which is not what I want. I only want to make the union cases private to the module.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Added inref interop test * Fixed inref interop when creating a slot sig * 3.1 to 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve this: davidfowl/BedrockFramework#48
Fix was easy, hardest part was making the test.
When importing an ILType when creating a TSlotParam, we didn't take into account the attributes, which there is a specific function for that. The attributes will dictate what kind of type we have, such as a
byrefparameter type with aReadOnlyAttribute; turns intoinref.