Skip to content

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented Jan 16, 2020

Not ready for merge, still need to manually check IDE behavior isn't broken, particularly around editor diagnostics.

The experimental F# LSP support isn't used anywhere and some of the tests are flaky. Rather than fix it for no good use, I'm just deleting it. If in the future we want to bring it back, git history will save us.

@brettfo brettfo requested a review from KevinRansom January 16, 2020 23:39
@brettfo brettfo changed the title delete experimental language server [WIP] delete experimental language server Jan 17, 2020
@brettfo brettfo changed the title [WIP] delete experimental language server delete experimental language server Jan 22, 2020
@brettfo brettfo merged commit 5a01170 into dotnet:master Jan 22, 2020
@brettfo brettfo deleted the delsp branch January 22, 2020 21:20
@brettfo brettfo mentioned this pull request Jan 23, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants