-
Notifications
You must be signed in to change notification settings - Fork 831
[RFC 1082] - uint type abbreviation #8185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Okay I think we have a serious bug here. fsharpqa is failing 217 tests related to IL generation and optimizations, which this absolutely doesn't touch. @KevinRansom @TIHan any thoughts? Could adding a type abbreviation really do that? |
|
I noticed these tests failing today. I thought it was a result of a WIP PR I have, but it does not seem to be the case. |
|
Okay this is a "something is wrong in the fsharp5 branch" problem, see here: #8196 Unfortunately it's merged into master |
|
@cartermp, you should add the experimental attribute, if this is for fsharp5 :-) [<Experimental(ExperimentalAttributeMessages.RequiresPreview)>] |
|
This will be just an incremental update to FSharp.Core instead of being gated by F# 5, even though it's a suggestion + RFC. Not much value in gating the change. |
* Add uint type abbreviation * Add uint casting function and test * Update surface area tests * update
RFC: https://github.com/fsharp/fslang-design/blob/master/RFCs/FS-1082-uint-type-abbreviation.md
Note that we apparently assume that
uintexists as a type abbreviation already, both in formatting and error messages:https://github.com/dotnet/fsharp/blob/master/src/utils/sformat.fs#L147
https://github.com/dotnet/fsharp/blob/master/src/fsharp/FSComp.txt#L790