Skip to content

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Jan 13, 2020

@cartermp
Copy link
Contributor Author

Okay I think we have a serious bug here. fsharpqa is failing 217 tests related to IL generation and optimizations, which this absolutely doesn't touch. @KevinRansom @TIHan any thoughts? Could adding a type abbreviation really do that?

@TIHan
Copy link
Contributor

TIHan commented Jan 14, 2020

I noticed these tests failing today. I thought it was a result of a WIP PR I have, but it does not seem to be the case.

@cartermp
Copy link
Contributor Author

Okay this is a "something is wrong in the fsharp5 branch" problem, see here: #8196

Unfortunately it's merged into master

@cartermp cartermp changed the title Add uint type abbreviation [RFC 1082] - uint type abbreviation Jan 15, 2020
@cartermp cartermp requested a review from dsyme January 15, 2020 01:05
@KevinRansom
Copy link
Contributor

@cartermp, you should add the experimental attribute, if this is for fsharp5 :-)

[<Experimental(ExperimentalAttributeMessages.RequiresPreview)>]

@cartermp
Copy link
Contributor Author

This will be just an incremental update to FSharp.Core instead of being gated by F# 5, even though it's a suggestion + RFC. Not much value in gating the change.

@KevinRansom KevinRansom merged commit db2ba9e into dotnet:master Jan 21, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Add uint type abbreviation

* Add uint casting function and test

* Update surface area tests

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants