Show C# and VB uses of an F# symbol in Find All References #20463
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| // Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information. | ||
|
|
||
| /// An F# library and a C# project referencing its built assembly, as VS wires a C# → F# project reference. | ||
| module FSharp.Editor.Tests.FindReferencesFromCSharpTests | ||
|
|
||
| open System | ||
| open System.Collections.Immutable | ||
| open System.IO | ||
| open System.Reflection | ||
| open System.Threading | ||
| open Xunit | ||
| open Microsoft.CodeAnalysis | ||
| open Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.FindUsages | ||
| open Microsoft.CodeAnalysis.ExternalAccess.FSharp.FindUsages | ||
| open Microsoft.CodeAnalysis.FindSymbols | ||
| open Microsoft.CodeAnalysis.Text | ||
| open Microsoft.VisualStudio.FSharp.Editor | ||
| open Microsoft.VisualStudio.FSharp.Editor.CancellableTasks | ||
| open FSharp.Editor.Tests.Helpers | ||
| open FSharp.Test.ProjectGeneration | ||
|
|
||
| let private library = | ||
| SyntheticProject.Create( | ||
| { sourceFile "First" [] with | ||
| ExtraSource = "let twice x = x * 2\n[<Literal>]\nlet answer = 42\n" | ||
| } | ||
| ) | ||
|
|
||
| /// The synthetic project puts its modules in a namespace named after the project. | ||
| let private moduleName = $"{library.Name}.ModuleFirst" | ||
|
|
||
| let private solution = | ||
| let librarySolution, checker = RoslynTestHelpers.CreateMultiProjectSolution library | ||
| let assembly = RoslynTestHelpers.CompileToAssembly(library, checker) | ||
|
|
||
| RoslynTestHelpers.AddCSharpProject( | ||
| librarySolution, | ||
| "Consumer", | ||
| $"class Consumer {{ int M() => {moduleName}.twice(1); int N() => {moduleName}.answer; }}", | ||
| library.GetProjectOptions checker, | ||
| [ assembly ] | ||
| ) | ||
|
|
||
| let private consumer = | ||
| solution.Projects |> Seq.find (fun p -> p.Language = LanguageNames.CSharp) | ||
|
|
||
| let private firstPath = library.GetFilePath "First" | ||
|
|
||
| let private declarationPosition = | ||
| (File.ReadAllText firstPath).IndexOf("twice", StringComparison.Ordinal) | ||
|
|
||
| let private fsharpDocument = | ||
| solution.GetDocumentIdsWithFilePath firstPath | ||
| |> Seq.exactlyOne | ||
| |> solution.GetDocument | ||
|
|
||
| let private findUsagesService = | ||
| FSharpFindUsagesService() :> IFSharpFindUsagesService | ||
|
|
||
| /// ExternalAccess exposes no span on a reference item; its Roslyn item is read through reflection. | ||
| let private documentSpanOf (reference: FSharpSourceReferenceItem) = | ||
| let flags = BindingFlags.Instance ||| BindingFlags.NonPublic ||| BindingFlags.Public | ||
|
|
||
| let property (target: obj) name = | ||
| target.GetType().GetProperty(name, flags).GetValue target | ||
|
|
||
| let documentSpan = | ||
| property (property reference "RoslynSourceReferenceItem") "SourceSpan" | ||
|
|
||
| property documentSpan "Document" :?> Document, property documentSpan "SourceSpan" :?> TextSpan | ||
|
|
||
| [<Fact>] | ||
| let ``the C# compilation resolves the doc comment id of an F# function`` () = | ||
| let compilation = consumer.GetCompilationAsync(CancellationToken.None).Result | ||
|
|
||
| let errors = | ||
| compilation.GetDiagnostics() | ||
| |> Seq.filter (fun d -> d.Severity = DiagnosticSeverity.Error) | ||
|
|
||
| Assert.Empty errors | ||
|
|
||
| let twice = | ||
| DocumentationCommentId.GetFirstSymbolForDeclarationId($"M:{moduleName}.twice(System.Int32)", compilation) | ||
|
|
||
| Assert.NotNull twice | ||
|
|
||
| let references = | ||
| SymbolFinder.FindReferencesAsync(twice, solution, ImmutableHashSet.CreateRange consumer.Documents, CancellationToken.None).Result | ||
|
|
||
| Assert.Single(references |> Seq.collect _.Locations) |> ignore | ||
|
|
||
| [<Fact>] | ||
| let ``the consumer is found as a project referencing the F# assembly`` () = | ||
| let referencing = | ||
| ProjectFiltering.getProjectsReferencingAssembly fsharpDocument.Project.OutputFilePath solution | ||
|
|
||
| Assert.Equal<ProjectId list>([ consumer.Id ], referencing |> List.map _.Id) | ||
|
|
||
| [<Theory>] | ||
| [<InlineData("twice", "M:{0}.twice(System.Int32)")>] | ||
| [<InlineData("ModuleFirst", "T:{0}")>] | ||
| [<InlineData("answer", "F:{0}.answer")>] | ||
| [<InlineData("x", null)>] | ||
| let ``DocumentationCommentId is the compiled form Roslyn resolves`` (symbolName: string, expectedFormat: string) = | ||
| let expected = | ||
| expectedFormat | ||
| |> ValueOption.ofObj | ||
| |> ValueOption.map (fun format -> String.Format(format, moduleName)) | ||
|
|
||
| let _, checkFileResults = | ||
| fsharpDocument.GetFSharpParseAndCheckResultsAsync "test" | ||
| |> CancellableTask.runSynchronouslyWithoutCancellation | ||
|
|
||
| let symbol = | ||
| checkFileResults.GetAllUsesOfAllSymbolsInFile() | ||
| |> Seq.find (fun symbolUse -> symbolUse.IsFromDefinition && symbolUse.Symbol.DisplayName = symbolName) | ||
| |> _.Symbol | ||
|
|
||
| Assert.Equal(expected, symbol.DocumentationCommentId) | ||
|
|
||
| [<Fact>] | ||
| let ``Find All References on an F# function reports its C# call site`` () = | ||
| let context, foundDefinitions, foundReferences = | ||
| RoslynTestHelpers.CreateFindUsagesContext() | ||
|
|
||
| findUsagesService.FindReferencesAsync(fsharpDocument, declarationPosition, context).Wait() | ||
|
|
||
| Assert.Equal(1, foundDefinitions.Count) | ||
| let document, span = documentSpanOf (Assert.Single foundReferences) | ||
| Assert.Equal(LanguageNames.CSharp, document.Project.Language) | ||
|
|
||
| let text = document.GetTextAsync(CancellationToken.None).Result | ||
| Assert.Equal("twice", text.ToString span) | ||
|
|
||
| [<Fact>] | ||
| let ``Find All References on an F# literal reports its C# use`` () = | ||
| let context, _, foundReferences = RoslynTestHelpers.CreateFindUsagesContext() | ||
|
|
||
| let position = | ||
| (File.ReadAllText firstPath).IndexOf("answer", StringComparison.Ordinal) | ||
|
|
||
| findUsagesService.FindReferencesAsync(fsharpDocument, position, context).Wait() | ||
|
|
||
| let document, span = documentSpanOf (Assert.Single foundReferences) | ||
| Assert.Equal(LanguageNames.CSharp, document.Project.Language) | ||
|
|
||
| let text = document.GetTextAsync(CancellationToken.None).Result | ||
| Assert.Equal("answer", text.ToString span) | ||
|
|
||
| [<Fact>] | ||
| let ``Find Implementations on an F# function does not report C# call sites`` () = | ||
| let context, _, foundReferences = RoslynTestHelpers.CreateFindUsagesContext() | ||
|
|
||
| findUsagesService.FindImplementationsAsync(fsharpDocument, declarationPosition, context).Wait() | ||
|
|
||
| Assert.Empty foundReferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖🕵️ Enum IDs do not resolve:
P:N.Color.Redreturns null, butF:N.Color.Redresolves the field.Map enum-field IDs to
F:and cover C#/VB callers.