Skip to content

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Oct 10, 2025

Apart from deterministic builds just make it the default. Let's see if it breaks.

EDIT: Also enable parallel IL gen.

@github-actions
Copy link
Contributor

❗ Release notes required

@majocha,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/11.0.0.md No release notes found or release notes format is not correct

@vzarytovskii
Copy link
Member

One thing to check - whether deterministic builds are default. If yes, it won't have any effect - debug builds don't run optimizer, and nobody really turning determinism off for production builds.

@majocha
Copy link
Contributor Author

majocha commented Oct 13, 2025

One thing to check - whether deterministic builds are default. If yes, it won't have any effect - debug builds don't run optimizer, and nobody really turning determinism off for production builds.

deterministic = false

It is off by default. I guess there are some legitimate dev scenarios when speeding up release build is useful, for example building release to run tests.

@vzarytovskii
Copy link
Member

One thing to check - whether deterministic builds are default. If yes, it won't have any effect - debug builds don't run optimizer, and nobody really turning determinism off for production builds.

deterministic = false

It is off by default. I guess there are some legitimate dev scenarios when speeding up release build is useful, for example building release to run tests.

It might be off by default in the compiler, but on by default in msbuild.

@majocha
Copy link
Contributor Author

majocha commented Oct 14, 2025

One thing to check - whether deterministic builds are default. If yes, it won't have any effect - debug builds don't run optimizer, and nobody really turning determinism off for production builds.

deterministic = false

It is off by default. I guess there are some legitimate dev scenarios when speeding up release build is useful, for example building release to run tests.

It might be off by default in the compiler, but on by default in msbuild.

Yes, needs checking. Looks like <Fsc> task is aligned with the defaults:

let mutable deterministic: bool = false

@majocha majocha closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants