-
Notifications
You must be signed in to change notification settings - Fork 832
Experiment: enable parallel optimization by default #18986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
One thing to check - whether deterministic builds are default. If yes, it won't have any effect - debug builds don't run optimizer, and nobody really turning determinism off for production builds. |
fsharp/src/Compiler/Driver/CompilerConfig.fs Line 817 in 753cb84
It is off by default. I guess there are some legitimate dev scenarios when speeding up release build is useful, for example building release to run tests. |
It might be off by default in the compiler, but on by default in msbuild. |
Yes, needs checking. Looks like fsharp/src/FSharp.Build/Fsc.fs Line 35 in bd346da
|
Apart from deterministic builds just make it the default. Let's see if it breaks.
EDIT: Also enable parallel IL gen.