Collect metrics from MemoizationTables #18936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MemoizationTablesuseConcurrentDictionaryas a backing store. If we use namedCacheinstances with no eviction instead, we can collect and see their metrics with--timesoption:In cases where there are many instances with the same name, the above data is accumulated by name.
possible TODOs: Identify other uses of
ConcurrentDictionarythat may be also instrumented like this. Maybe collect some more useful data, currently hit ratio is computed, the rest are just raw event counts as they come from the Cache.