Skip to content

Conversation

Martin521
Copy link
Contributor

@Martin521 Martin521 commented Sep 18, 2025

Description

Fixes #18908

That was easier than I thought.

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Sep 18, 2025
@T-Gro
Copy link
Member

T-Gro commented Sep 18, 2025

Thank you @Martin521 for fixing it that quickly.
Surprisingly we do not have any tests for VS.FSI, the window in VS itself - replicating that as standalone F# snippet has to suffice.

@Martin521
Copy link
Contributor Author

I am also not yet sure if this really has fixed the fsi issue already. I will continue tomorrow.

@Martin521 Martin521 marked this pull request as draft September 19, 2025 07:32
@Martin521 Martin521 marked this pull request as ready for review September 19, 2025 09:49
@Martin521
Copy link
Contributor Author

This should be ok now. The remaining test failures in WindowsXX_testDesktop4 seem to be unrelated to this PR.

@T-Gro
Copy link
Member

T-Gro commented Sep 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Martin521
Copy link
Contributor Author

The failing test is puzzling me.
The test fails only in the two Windows...Desktop4 jobs, but consistently.
It fails because instead of Error 1204 a Warning 1204 is reported.
It seems this #if directive evaluates differently.
But I have no idea why this is happening for this PR and not for other PRs that ran today.
It seems to be impossible that this is related to my changes.

@T-Gro
Copy link
Member

T-Gro commented Sep 22, 2025

@Martin521 : It is deterministic, I also do not believe this is a flaky test anymore.
Something in this change is causing a difference in how the diagnostic gets produced.

@T-Gro T-Gro merged commit 0827571 into dotnet:main Sep 22, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

VS 2026 preview: FSI evaluation doesn't report correct line numbers

2 participants