Skip to content

Fix expected and actual types in ErrorFromAddingTypeEquation message and extended diagnostic data #18915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2025
Merged

Fix expected and actual types in ErrorFromAddingTypeEquation message and extended diagnostic data #18915

merged 6 commits into from
Sep 25, 2025

Conversation

@DedSec256
Copy link
Contributor

@DedSec256 DedSec256 commented Sep 17, 2025 •
edited
Loading

Fix for #18905

Currently, expected and actual types are swapped in several compiler errors, both in the error message and in the extended diagnostic data.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@DedSec256 DedSec256 changed the title Fix [Experiment] Fix expected and actual types in several compiler errors and their extended diagnostic data [Experiment] Sep 23, 2025
@DedSec256 DedSec256 force-pushed the ber.a/fixTypeMismatchError branch 2 times, most recently from e27d3d9 to 4bf05e7 Compare September 24, 2025 01:01
@DedSec256 DedSec256 force-pushed the ber.a/fixTypeMismatchError branch from 4bf05e7 to d6fa56e Compare September 24, 2025 01:28
auduchinok
auduchinok approved these changes Sep 24, 2025
View reviewed changes
@DedSec256 DedSec256 changed the title Fix expected and actual types in several compiler errors and their extended diagnostic data [Experiment] Fix expected and actual types in ErrorFromAddingTypeEquation messages and extended diagnostic data Sep 24, 2025
@DedSec256 DedSec256 changed the title Fix expected and actual types in ErrorFromAddingTypeEquation messages and extended diagnostic data Fix expected and actual types in ErrorFromAddingTypeEquation message and extended diagnostic data Sep 24, 2025
@DedSec256 DedSec256 marked this pull request as ready for review September 24, 2025 16:51
@DedSec256 DedSec256 requested a review from a team as a code owner September 24, 2025 16:51
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Sep 25, 2025
@T-Gro T-Gro merged commit bf88205 into dotnet:main Sep 25, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Sep 25, 2025
This was referenced Oct 14, 2025
Closed
Closed
Closed
Closed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@auduchinok auduchinok auduchinok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DedSec256 @auduchinok @T-Gro