Cache: immediate eviction in net4 tests #18889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I think this is needed after all. |
T-Gro
reviewed
Sep 10, 2025
T-Gro
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Sep 25, 2025
This was referenced Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm noticing some CI hangs on .Net Framework tests after #18875
The cause may or may not be thread pool starvation: old .Net uses different algorithms and does not ramp up threads fast enough.
Specifically after #18875 the type subsumption cache is tied to TcGlobals, which means more instances instead of one per process singleton. Unfortunately, in tests it means thousand started in quick succession. So, the queued eviction for each one eats some threads, quickly.
So, if the problem persists, this should be a fix.