Skip to content

Conversation

@majocha
Copy link
Contributor

@majocha majocha commented Jun 2, 2025

Resolves #18623, fixes #18904

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
vsintegration/src docs/release-notes/.VisualStudio/18.0.md

@majocha
Copy link
Contributor Author

majocha commented Jun 2, 2025

Works ok in experimental instance. It seems we don't need the UI thread during package init.
This must wait because currently the vsix cannot be installed

@T-Gro
Copy link
Member

T-Gro commented Jun 3, 2025

Thanks for taking this up @majocha .
This has the potential to speed up solution opening, so I am really glad the new API model allows us to make this split.

Lets merge this in after it can be locally tested.

@majocha
Copy link
Contributor Author

majocha commented Sep 16, 2025

I included fix for #18904. The setting was never set because the Initialize method was never called. We could extract the fix to another PR if needed.

@majocha majocha marked this pull request as ready for review September 16, 2025 18:55
@majocha majocha requested a review from a team as a code owner September 16, 2025 18:56
@T-Gro
Copy link
Member

T-Gro commented Sep 17, 2025

I included fix for #18904. The setting was never set because the Initialize method was never called. We could extract the fix to another PR if needed.

Excellent for finding that out, @majocha . No need to extract it, we can keep it as a single PR bere.

@majocha
Copy link
Contributor Author

majocha commented Sep 17, 2025

I'm testing this PR atm. It seems fine now. FSI initializes ok. If there are any problems, (for example deadlocks at startup) it's a matter of moving some things from the background to foreground init.

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Sep 17, 2025
@T-Gro
Copy link
Member

T-Gro commented Sep 17, 2025

I am going to merge this as it fixes an important user-facing regression with the solution crawler.
(especially on large solutions this would degrade the experience a lot)

@majocha : You are our hero 👍 !

@T-Gro
Copy link
Member

T-Gro commented Oct 23, 2025

/backport to release/dev18.0

@github-actions
Copy link
Contributor

Started backporting to release/dev18.0: https://github.com/dotnet/fsharp/actions/runs/18745823459

@github-actions
Copy link
Contributor

@T-Gro backporting to "release/dev18.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: vs initialize in background
Using index info to reconstruct a base tree...
M	vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
Falling back to patching base and 3-way merge...
Auto-merging vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
CONFLICT (content): Merge conflict in vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 vs initialize in background
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

VS 2026 does not respect SolutionBackgroundAnalysis setting. Split VS F# Package init into foreground+background work

3 participants